summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorbunnei <bunneidev@gmail.com>2016-02-25 03:15:16 +0100
committerbunnei <bunneidev@gmail.com>2016-02-25 03:15:16 +0100
commite04e6aabbc7bbd2bc3a08a6cecd50273670ca0a6 (patch)
tree1284522b384099dbab578007260fbaa2e3932012 /src
parentMerge pull request #1406 from MerryMage/bitfield2 (diff)
parentFix out of bounds array access when loading a component >= 12 (diff)
downloadyuzu-e04e6aabbc7bbd2bc3a08a6cecd50273670ca0a6.tar
yuzu-e04e6aabbc7bbd2bc3a08a6cecd50273670ca0a6.tar.gz
yuzu-e04e6aabbc7bbd2bc3a08a6cecd50273670ca0a6.tar.bz2
yuzu-e04e6aabbc7bbd2bc3a08a6cecd50273670ca0a6.tar.lz
yuzu-e04e6aabbc7bbd2bc3a08a6cecd50273670ca0a6.tar.xz
yuzu-e04e6aabbc7bbd2bc3a08a6cecd50273670ca0a6.tar.zst
yuzu-e04e6aabbc7bbd2bc3a08a6cecd50273670ca0a6.zip
Diffstat (limited to 'src')
-rw-r--r--src/video_core/command_processor.cpp24
1 files changed, 17 insertions, 7 deletions
diff --git a/src/video_core/command_processor.cpp b/src/video_core/command_processor.cpp
index ed20057b5..73fdfbe9c 100644
--- a/src/video_core/command_processor.cpp
+++ b/src/video_core/command_processor.cpp
@@ -157,15 +157,25 @@ static void WritePicaReg(u32 id, u32 value, u32 mask) {
// TODO: What happens if a loader overwrites a previous one's data?
for (unsigned component = 0; component < loader_config.component_count; ++component) {
- if (component >= 12)
+ if (component >= 12) {
LOG_ERROR(HW_GPU, "Overflow in the vertex attribute loader %u trying to load component %u", loader, component);
+ continue;
+ }
+
u32 attribute_index = loader_config.GetComponent(component);
- vertex_attribute_sources[attribute_index] = load_address;
- vertex_attribute_strides[attribute_index] = static_cast<u32>(loader_config.byte_count);
- vertex_attribute_formats[attribute_index] = attribute_config.GetFormat(attribute_index);
- vertex_attribute_elements[attribute_index] = attribute_config.GetNumElements(attribute_index);
- vertex_attribute_element_size[attribute_index] = attribute_config.GetElementSizeInBytes(attribute_index);
- load_address += attribute_config.GetStride(attribute_index);
+ if (attribute_index < 12) {
+ vertex_attribute_sources[attribute_index] = load_address;
+ vertex_attribute_strides[attribute_index] = static_cast<u32>(loader_config.byte_count);
+ vertex_attribute_formats[attribute_index] = attribute_config.GetFormat(attribute_index);
+ vertex_attribute_elements[attribute_index] = attribute_config.GetNumElements(attribute_index);
+ vertex_attribute_element_size[attribute_index] = attribute_config.GetElementSizeInBytes(attribute_index);
+ load_address += attribute_config.GetStride(attribute_index);
+ } else if (attribute_index < 16) {
+ // Attribute ids 12, 13, 14 and 15 signify 4, 8, 12 and 16-byte paddings, respectively
+ load_address += (attribute_index - 11) * 4;
+ } else {
+ UNREACHABLE(); // This is truly unreachable due to the number of bits for each component
+ }
}
}