summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorSubv <subv2112@gmail.com>2017-10-04 18:49:29 +0200
committerSubv <subv2112@gmail.com>2017-10-04 19:30:33 +0200
commit0cfb231e002629172337c048e8cabc8c653e34e3 (patch)
tree217133327f9817305d592cd4eee1d8bed53c8784 /src
parentSVC: Replace GetPointer usage with Read32 in WaitSynchronizationN. (diff)
downloadyuzu-0cfb231e002629172337c048e8cabc8c653e34e3.tar
yuzu-0cfb231e002629172337c048e8cabc8c653e34e3.tar.gz
yuzu-0cfb231e002629172337c048e8cabc8c653e34e3.tar.bz2
yuzu-0cfb231e002629172337c048e8cabc8c653e34e3.tar.lz
yuzu-0cfb231e002629172337c048e8cabc8c653e34e3.tar.xz
yuzu-0cfb231e002629172337c048e8cabc8c653e34e3.tar.zst
yuzu-0cfb231e002629172337c048e8cabc8c653e34e3.zip
Diffstat (limited to 'src')
-rw-r--r--src/core/hle/function_wrappers.h5
-rw-r--r--src/core/hle/svc.cpp8
2 files changed, 6 insertions, 7 deletions
diff --git a/src/core/hle/function_wrappers.h b/src/core/hle/function_wrappers.h
index 17892d81c..cd500e83d 100644
--- a/src/core/hle/function_wrappers.h
+++ b/src/core/hle/function_wrappers.h
@@ -69,11 +69,10 @@ void Wrap() {
FuncReturn(retval);
}
-template <ResultCode func(s32*, u32*, s32, u32)>
+template <ResultCode func(s32*, VAddr, s32, u32)>
void Wrap() {
s32 param_1 = 0;
- u32 retval =
- func(&param_1, (Kernel::Handle*)Memory::GetPointer(PARAM(1)), (s32)PARAM(2), PARAM(3)).raw;
+ u32 retval = func(&param_1, PARAM(1), (s32)PARAM(2), PARAM(3)).raw;
Core::CPU().SetReg(1, (u32)param_1);
FuncReturn(retval);
diff --git a/src/core/hle/svc.cpp b/src/core/hle/svc.cpp
index 9edce7ab7..61360bede 100644
--- a/src/core/hle/svc.cpp
+++ b/src/core/hle/svc.cpp
@@ -452,10 +452,9 @@ static ResultCode WaitSynchronizationN(s32* out, VAddr handles_address, s32 hand
}
/// In a single operation, sends a IPC reply and waits for a new request.
-static ResultCode ReplyAndReceive(s32* index, Kernel::Handle* handles, s32 handle_count,
+static ResultCode ReplyAndReceive(s32* index, VAddr handles_address, s32 handle_count,
Kernel::Handle reply_target) {
- // 'handles' has to be a valid pointer even if 'handle_count' is 0.
- if (handles == nullptr)
+ if (!Memory::IsValidVirtualAddress(handles_address))
return Kernel::ERR_INVALID_POINTER;
// Check if 'handle_count' is invalid
@@ -466,7 +465,8 @@ static ResultCode ReplyAndReceive(s32* index, Kernel::Handle* handles, s32 handl
std::vector<ObjectPtr> objects(handle_count);
for (int i = 0; i < handle_count; ++i) {
- auto object = Kernel::g_handle_table.Get<Kernel::WaitObject>(handles[i]);
+ Kernel::Handle handle = Memory::Read32(handles_address + i * sizeof(Kernel::Handle));
+ auto object = Kernel::g_handle_table.Get<Kernel::WaitObject>(handle);
if (object == nullptr)
return ERR_INVALID_HANDLE;
objects[i] = object;