summaryrefslogtreecommitdiffstats
path: root/src/core
diff options
context:
space:
mode:
authorFrederic Laing <27208977+FreddyFunk@users.noreply.github.com>2018-11-06 10:21:01 +0100
committerFrederic Laing <27208977+FreddyFunk@users.noreply.github.com>2018-11-06 10:21:01 +0100
commitba2cdcdc5ab0c671b78b9446728dc9de89592e5a (patch)
tree4ebf53372fa93e5976e20fd6d8807402686ef4a3 /src/core
parentStubbed SetMemoryPermission (diff)
downloadyuzu-ba2cdcdc5ab0c671b78b9446728dc9de89592e5a.tar
yuzu-ba2cdcdc5ab0c671b78b9446728dc9de89592e5a.tar.gz
yuzu-ba2cdcdc5ab0c671b78b9446728dc9de89592e5a.tar.bz2
yuzu-ba2cdcdc5ab0c671b78b9446728dc9de89592e5a.tar.lz
yuzu-ba2cdcdc5ab0c671b78b9446728dc9de89592e5a.tar.xz
yuzu-ba2cdcdc5ab0c671b78b9446728dc9de89592e5a.tar.zst
yuzu-ba2cdcdc5ab0c671b78b9446728dc9de89592e5a.zip
Diffstat (limited to 'src/core')
-rw-r--r--src/core/hle/kernel/svc.cpp42
1 files changed, 39 insertions, 3 deletions
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp
index 56e7904a5..3b1612bad 100644
--- a/src/core/hle/kernel/svc.cpp
+++ b/src/core/hle/kernel/svc.cpp
@@ -123,9 +123,45 @@ static ResultCode SetHeapSize(VAddr* heap_addr, u64 heap_size) {
}
static ResultCode SetMemoryPermission(VAddr addr, u64 size, u32 prot) {
- LOG_WARNING(Kernel_SVC, "(STUBBED) called, addr=0x{:X}, size=0x{:X}, prot=0x{:X}", addr, size,
- prot);
- return RESULT_SUCCESS;
+ LOG_TRACE(Kernel_SVC, "called, addr=0x{:X}, size=0x{:X}, prot=0x{:X}", addr, size, prot);
+
+ if (!Common::Is4KBAligned(addr)) {
+ return ERR_INVALID_ADDRESS;
+ }
+
+ if (size == 0 || !Common::Is4KBAligned(size)) {
+ return ERR_INVALID_SIZE;
+ }
+
+ if (!IsValidAddressRange(addr, size)) {
+ return ERR_INVALID_ADDRESS_STATE;
+ }
+
+ const auto permission = static_cast<MemoryPermission>(prot);
+ if (permission != MemoryPermission::None && permission != MemoryPermission::Read &&
+ permission != MemoryPermission::ReadWrite) {
+ return ERR_INVALID_MEMORY_PERMISSIONS;
+ }
+
+ auto* const current_process = Core::CurrentProcess();
+ auto& vm_manager = current_process->VMManager();
+
+ if (!IsInsideAddressSpace(vm_manager, addr, size)) {
+ return ERR_INVALID_ADDRESS_STATE;
+ }
+
+ const VMManager::VMAHandle iter = vm_manager.FindVMA(addr);
+ if (iter == vm_manager.vma_map.end()) {
+ return ERR_INVALID_ADDRESS_STATE;
+ }
+
+ LOG_WARNING(Kernel_SVC, "Uniformity check on protected memory is not implemented.");
+ // TODO: Performs a uniformity check to make sure only protected memory is changed (it doesn't
+ // make sense to allow changing permissions on kernel memory itself, etc).
+
+ const auto converted_permissions = SharedMemory::ConvertPermissions(permission);
+
+ return vm_manager.ReprotectRange(addr, size, converted_permissions);
}
static ResultCode SetMemoryAttribute(VAddr addr, u64 size, u32 state0, u32 state1) {