summaryrefslogtreecommitdiffstats
path: root/src/core
diff options
context:
space:
mode:
authorbunnei <bunneidev@gmail.com>2015-01-17 18:17:36 +0100
committerbunnei <bunneidev@gmail.com>2015-01-22 01:09:09 +0100
commit064be2b86f166d40e0ba61bc4ec0306631b4be9f (patch)
treeee94c2f99c29135af939094c70f966905e3f4bc0 /src/core
parentWaitSynchronizationN: Implement return values (diff)
downloadyuzu-064be2b86f166d40e0ba61bc4ec0306631b4be9f.tar
yuzu-064be2b86f166d40e0ba61bc4ec0306631b4be9f.tar.gz
yuzu-064be2b86f166d40e0ba61bc4ec0306631b4be9f.tar.bz2
yuzu-064be2b86f166d40e0ba61bc4ec0306631b4be9f.tar.lz
yuzu-064be2b86f166d40e0ba61bc4ec0306631b4be9f.tar.xz
yuzu-064be2b86f166d40e0ba61bc4ec0306631b4be9f.tar.zst
yuzu-064be2b86f166d40e0ba61bc4ec0306631b4be9f.zip
Diffstat (limited to 'src/core')
-rw-r--r--src/core/hle/svc.cpp48
1 files changed, 29 insertions, 19 deletions
diff --git a/src/core/hle/svc.cpp b/src/core/hle/svc.cpp
index 170ac87f3..f8a5b2548 100644
--- a/src/core/hle/svc.cpp
+++ b/src/core/hle/svc.cpp
@@ -148,27 +148,37 @@ static Result WaitSynchronizationN(s32* out, Handle* handles, s32 handle_count,
bool wait_all_succeeded = false;
int handle_index = 0;
- while (handle_index < handle_count) {
- SharedPtr<Kernel::Object> object = Kernel::g_handle_table.GetGeneric(handles[handle_index]);
- if (object == nullptr)
- return InvalidHandle(ErrorModule::Kernel).raw;
-
- ResultVal<bool> wait = object->WaitSynchronization(handle_index);
-
- wait_thread = (wait.Succeeded() && *wait);
+ // If handles were passed in, iterate through them and wait/acquire the objects as needed
+ if (handle_count > 0) {
+ while (handle_index < handle_count) {
+ SharedPtr<Kernel::Object> object = Kernel::g_handle_table.GetGeneric(handles[handle_index]);
+ if (object == nullptr)
+ return InvalidHandle(ErrorModule::Kernel).raw;
+
+ ResultVal<bool> wait = object->WaitSynchronization(handle_index);
+
+ wait_thread = (wait.Succeeded() && *wait);
+
+ // If this object waited and we are waiting on all objects to synchronize
+ if (wait_thread && wait_all) {
+ // Enforce later on that this thread does not continue
+ wait_all_succeeded = true;
+ }
+
+ // If this object synchronized and we are not waiting on all objects to synchronize
+ if (!wait_thread && !wait_all)
+ // We're done, the thread will continue
+ break;
- // If this object waited and we are waiting on all objects to synchronize
- if (wait_thread && wait_all) {
- // Enforce later on that this thread does not continue
- wait_all_succeeded = true;
+ handle_index++;
+ }
+ }else {
+ // If no handles were passed in, put the thread to sleep only when wait_all=false
+ // NOTE: This is supposed to deadlock if no timeout was specified
+ if (!wait_all) {
+ wait_thread = true;
+ Kernel::WaitCurrentThread(WAITTYPE_SLEEP);
}
-
- // If this object synchronized and we are not waiting on all objects to synchronize
- if (!wait_thread && !wait_all)
- // We're done, the thread will continue
- break;
-
- handle_index++;
}
// Change the thread state to waiting if blocking on all handles...