summaryrefslogtreecommitdiffstats
path: root/src/core/hle
diff options
context:
space:
mode:
authorbunnei <bunneidev@gmail.com>2018-08-13 04:05:48 +0200
committerGitHub <noreply@github.com>2018-08-13 04:05:48 +0200
commite4ed5bc83610b7538f3a8ea355a3ed2437c87671 (patch)
tree7ae20333761b95790d6d263539f8607084982b38 /src/core/hle
parentMerge pull request #1041 from Subv/duplicated_mutex (diff)
parentCore/HLE: Make the 'reschedule_pending' flag atomic. (diff)
downloadyuzu-e4ed5bc83610b7538f3a8ea355a3ed2437c87671.tar
yuzu-e4ed5bc83610b7538f3a8ea355a3ed2437c87671.tar.gz
yuzu-e4ed5bc83610b7538f3a8ea355a3ed2437c87671.tar.bz2
yuzu-e4ed5bc83610b7538f3a8ea355a3ed2437c87671.tar.lz
yuzu-e4ed5bc83610b7538f3a8ea355a3ed2437c87671.tar.xz
yuzu-e4ed5bc83610b7538f3a8ea355a3ed2437c87671.tar.zst
yuzu-e4ed5bc83610b7538f3a8ea355a3ed2437c87671.zip
Diffstat (limited to 'src/core/hle')
-rw-r--r--src/core/hle/kernel/thread.cpp11
1 files changed, 9 insertions, 2 deletions
diff --git a/src/core/hle/kernel/thread.cpp b/src/core/hle/kernel/thread.cpp
index 40918ca81..a1a7867ce 100644
--- a/src/core/hle/kernel/thread.cpp
+++ b/src/core/hle/kernel/thread.cpp
@@ -23,6 +23,7 @@
#include "core/hle/kernel/object.h"
#include "core/hle/kernel/process.h"
#include "core/hle/kernel/thread.h"
+#include "core/hle/lock.h"
#include "core/hle/result.h"
#include "core/memory.h"
@@ -104,6 +105,10 @@ void ExitCurrentThread() {
*/
static void ThreadWakeupCallback(u64 thread_handle, int cycles_late) {
const auto proper_handle = static_cast<Handle>(thread_handle);
+
+ // Lock the global kernel mutex when we enter the kernel HLE.
+ std::lock_guard<std::recursive_mutex> lock(HLE::g_hle_lock);
+
SharedPtr<Thread> thread = wakeup_callback_handle_table.Get<Thread>(proper_handle);
if (thread == nullptr) {
LOG_CRITICAL(Kernel, "Callback fired for invalid thread {:08X}", proper_handle);
@@ -155,8 +160,10 @@ void Thread::WakeAfterDelay(s64 nanoseconds) {
if (nanoseconds == -1)
return;
- CoreTiming::ScheduleEvent(CoreTiming::nsToCycles(nanoseconds), ThreadWakeupEventType,
- callback_handle);
+ // This function might be called from any thread so we have to be cautious and use the
+ // thread-safe version of ScheduleEvent.
+ CoreTiming::ScheduleEventThreadsafe(CoreTiming::nsToCycles(nanoseconds), ThreadWakeupEventType,
+ callback_handle);
}
void Thread::CancelWakeupTimer() {