summaryrefslogtreecommitdiffstats
path: root/src/core/hle/service/vi
diff options
context:
space:
mode:
authorLiam <byteslice@airmail.cc>2024-01-18 04:03:40 +0100
committerLiam <byteslice@airmail.cc>2024-01-18 04:03:40 +0100
commite4bbb24dcf9048ac23e6c12f2ab5af1e988af764 (patch)
treeef5c985bcc765c02da9e443140de55228ed4134d /src/core/hle/service/vi
parentnvnflinger: ensure display abandonment considers all layers and future layers (diff)
downloadyuzu-e4bbb24dcf9048ac23e6c12f2ab5af1e988af764.tar
yuzu-e4bbb24dcf9048ac23e6c12f2ab5af1e988af764.tar.gz
yuzu-e4bbb24dcf9048ac23e6c12f2ab5af1e988af764.tar.bz2
yuzu-e4bbb24dcf9048ac23e6c12f2ab5af1e988af764.tar.lz
yuzu-e4bbb24dcf9048ac23e6c12f2ab5af1e988af764.tar.xz
yuzu-e4bbb24dcf9048ac23e6c12f2ab5af1e988af764.tar.zst
yuzu-e4bbb24dcf9048ac23e6c12f2ab5af1e988af764.zip
Diffstat (limited to 'src/core/hle/service/vi')
-rw-r--r--src/core/hle/service/vi/layer/vi_layer.h9
-rw-r--r--src/core/hle/service/vi/vi.cpp14
2 files changed, 17 insertions, 6 deletions
diff --git a/src/core/hle/service/vi/layer/vi_layer.h b/src/core/hle/service/vi/layer/vi_layer.h
index 295005e23..f95e2dc71 100644
--- a/src/core/hle/service/vi/layer/vi_layer.h
+++ b/src/core/hle/service/vi/layer/vi_layer.h
@@ -4,6 +4,7 @@
#pragma once
#include <memory>
+#include <utility>
#include "common/common_types.h"
@@ -75,12 +76,12 @@ public:
return open;
}
- void Close() {
- open = false;
+ bool Close() {
+ return std::exchange(open, false);
}
- void Open() {
- open = true;
+ bool Open() {
+ return !std::exchange(open, true);
}
private:
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp
index 39d5be90d..bfcc27ddc 100644
--- a/src/core/hle/service/vi/vi.cpp
+++ b/src/core/hle/service/vi/vi.cpp
@@ -719,7 +719,12 @@ private:
return;
}
- nvnflinger.OpenLayer(layer_id);
+ if (!nvnflinger.OpenLayer(layer_id)) {
+ LOG_WARNING(Service_VI, "Tried to open layer which was already open");
+ IPC::ResponseBuilder rb{ctx, 2};
+ rb.Push(ResultOperationFailed);
+ return;
+ }
android::OutputParcel parcel;
parcel.WriteInterface(NativeWindow{*buffer_queue_id});
@@ -737,7 +742,12 @@ private:
LOG_DEBUG(Service_VI, "called. layer_id=0x{:016X}", layer_id);
- nvnflinger.CloseLayer(layer_id);
+ if (!nvnflinger.CloseLayer(layer_id)) {
+ LOG_WARNING(Service_VI, "Tried to close layer which was not open");
+ IPC::ResponseBuilder rb{ctx, 2};
+ rb.Push(ResultOperationFailed);
+ return;
+ }
IPC::ResponseBuilder rb{ctx, 2};
rb.Push(ResultSuccess);