summaryrefslogtreecommitdiffstats
path: root/src/core/file_sys
diff options
context:
space:
mode:
authorbunnei <bunneidev@gmail.com>2018-07-21 20:38:52 +0200
committerGitHub <noreply@github.com>2018-07-21 20:38:52 +0200
commit0f20fa5a1e179bdad07fe1e0e58243d1927274fd (patch)
tree1e36cf5bf5bb44a6c77087dfd7161b72739dbf3e /src/core/file_sys
parentMerge pull request #750 from lioncash/ctx (diff)
parentvfs_real: Remove redundant copying of std::vector instances in GetFiles() and GetSubdirectories() (diff)
downloadyuzu-0f20fa5a1e179bdad07fe1e0e58243d1927274fd.tar
yuzu-0f20fa5a1e179bdad07fe1e0e58243d1927274fd.tar.gz
yuzu-0f20fa5a1e179bdad07fe1e0e58243d1927274fd.tar.bz2
yuzu-0f20fa5a1e179bdad07fe1e0e58243d1927274fd.tar.lz
yuzu-0f20fa5a1e179bdad07fe1e0e58243d1927274fd.tar.xz
yuzu-0f20fa5a1e179bdad07fe1e0e58243d1927274fd.tar.zst
yuzu-0f20fa5a1e179bdad07fe1e0e58243d1927274fd.zip
Diffstat (limited to 'src/core/file_sys')
-rw-r--r--src/core/file_sys/partition_filesystem.cpp12
-rw-r--r--src/core/file_sys/vfs_real.cpp16
2 files changed, 20 insertions, 8 deletions
diff --git a/src/core/file_sys/partition_filesystem.cpp b/src/core/file_sys/partition_filesystem.cpp
index 7ccca1089..8d2bd9f6b 100644
--- a/src/core/file_sys/partition_filesystem.cpp
+++ b/src/core/file_sys/partition_filesystem.cpp
@@ -2,7 +2,12 @@
// Licensed under GPLv2 or any later version
// Refer to the license.txt file included.
+#include <algorithm>
+#include <cstddef>
+#include <cstring>
+#include <iterator>
#include <utility>
+
#include "common/file_util.h"
#include "common/logging/log.h"
#include "core/file_sys/partition_filesystem.h"
@@ -99,14 +104,15 @@ void PartitionFilesystem::PrintDebugInfo() const {
}
bool PartitionFilesystem::ReplaceFileWithSubdirectory(VirtualFile file, VirtualDir dir) {
- auto iter = std::find(pfs_files.begin(), pfs_files.end(), file);
+ const auto iter = std::find(pfs_files.begin(), pfs_files.end(), file);
if (iter == pfs_files.end())
return false;
- pfs_files[iter - pfs_files.begin()] = pfs_files.back();
+ const std::ptrdiff_t offset = std::distance(pfs_files.begin(), iter);
+ pfs_files[offset] = pfs_files.back();
pfs_files.pop_back();
- pfs_dirs.emplace_back(dir);
+ pfs_dirs.emplace_back(std::move(dir));
return true;
}
diff --git a/src/core/file_sys/vfs_real.cpp b/src/core/file_sys/vfs_real.cpp
index 22c858e0d..f27fb1f2a 100644
--- a/src/core/file_sys/vfs_real.cpp
+++ b/src/core/file_sys/vfs_real.cpp
@@ -2,6 +2,11 @@
// Licensed under GPLv2 or any later version
// Refer to the license.txt file included.
+#include <algorithm>
+#include <cstddef>
+#include <iterator>
+#include <utility>
+
#include "common/common_paths.h"
#include "common/logging/log.h"
#include "core/file_sys/vfs_real.h"
@@ -104,11 +109,11 @@ RealVfsDirectory::RealVfsDirectory(const std::string& path_, Mode perms_)
}
std::vector<std::shared_ptr<VfsFile>> RealVfsDirectory::GetFiles() const {
- return std::vector<std::shared_ptr<VfsFile>>(files);
+ return files;
}
std::vector<std::shared_ptr<VfsDirectory>> RealVfsDirectory::GetSubdirectories() const {
- return std::vector<std::shared_ptr<VfsDirectory>>(subdirectories);
+ return subdirectories;
}
bool RealVfsDirectory::IsWritable() const {
@@ -163,14 +168,15 @@ bool RealVfsDirectory::Rename(const std::string& name) {
}
bool RealVfsDirectory::ReplaceFileWithSubdirectory(VirtualFile file, VirtualDir dir) {
- auto iter = std::find(files.begin(), files.end(), file);
+ const auto iter = std::find(files.begin(), files.end(), file);
if (iter == files.end())
return false;
- files[iter - files.begin()] = files.back();
+ const std::ptrdiff_t offset = std::distance(files.begin(), iter);
+ files[offset] = files.back();
files.pop_back();
- subdirectories.emplace_back(dir);
+ subdirectories.emplace_back(std::move(dir));
return true;
}