summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbunnei <bunneidev@gmail.com>2018-08-12 04:18:40 +0200
committerGitHub <noreply@github.com>2018-08-12 04:18:40 +0200
commitd37da52cb331b56ddab6990e379489fd517531d9 (patch)
tree2ade680ffb8fcafb64c88dfd7c1ad4158d7dfc1d
parentImplement R8_UINT RenderTargetFormat & PixelFormat (#1014) (diff)
parentRasterizerGL: Ignore invalid/unset vertex attributes. (diff)
downloadyuzu-d37da52cb331b56ddab6990e379489fd517531d9.tar
yuzu-d37da52cb331b56ddab6990e379489fd517531d9.tar.gz
yuzu-d37da52cb331b56ddab6990e379489fd517531d9.tar.bz2
yuzu-d37da52cb331b56ddab6990e379489fd517531d9.tar.lz
yuzu-d37da52cb331b56ddab6990e379489fd517531d9.tar.xz
yuzu-d37da52cb331b56ddab6990e379489fd517531d9.tar.zst
yuzu-d37da52cb331b56ddab6990e379489fd517531d9.zip
-rw-r--r--src/video_core/engines/maxwell_3d.h5
-rw-r--r--src/video_core/renderer_opengl/gl_rasterizer.cpp7
2 files changed, 11 insertions, 1 deletions
diff --git a/src/video_core/engines/maxwell_3d.h b/src/video_core/engines/maxwell_3d.h
index 0506ac8fe..d795323b0 100644
--- a/src/video_core/engines/maxwell_3d.h
+++ b/src/video_core/engines/maxwell_3d.h
@@ -93,6 +93,7 @@ public:
struct VertexAttribute {
enum class Size : u32 {
+ Invalid = 0x0,
Size_32_32_32_32 = 0x01,
Size_32_32_32 = 0x02,
Size_16_16_16_16 = 0x03,
@@ -257,6 +258,10 @@ public:
bool IsNormalized() const {
return (type == Type::SignedNorm) || (type == Type::UnsignedNorm);
}
+
+ bool IsValid() const {
+ return size != Size::Invalid;
+ }
};
enum class PrimitiveTopology : u32 {
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.cpp b/src/video_core/renderer_opengl/gl_rasterizer.cpp
index 8360feb5d..3646a1b1b 100644
--- a/src/video_core/renderer_opengl/gl_rasterizer.cpp
+++ b/src/video_core/renderer_opengl/gl_rasterizer.cpp
@@ -161,11 +161,16 @@ std::pair<u8*, GLintptr> RasterizerOpenGL::SetupVertexArrays(u8* array_ptr,
// assume every shader uses them all.
for (unsigned index = 0; index < 16; ++index) {
auto& attrib = regs.vertex_attrib_format[index];
+
+ // Ignore invalid attributes.
+ if (!attrib.IsValid())
+ continue;
+
+ auto& buffer = regs.vertex_array[attrib.buffer];
LOG_TRACE(HW_GPU, "vertex attrib {}, count={}, size={}, type={}, offset={}, normalize={}",
index, attrib.ComponentCount(), attrib.SizeString(), attrib.TypeString(),
attrib.offset.Value(), attrib.IsNormalized());
- auto& buffer = regs.vertex_array[attrib.buffer];
ASSERT(buffer.IsEnabled());
glEnableVertexAttribArray(index);