summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFreddyFunk <FreddyFunk@users.noreply.github.com>2019-10-10 23:12:06 +0200
committerFreddyFunk <FreddyFunk@users.noreply.github.com>2019-10-10 23:12:06 +0200
commita31c6b2c4e989b6035364cb4ceed44f412f037b7 (patch)
treee408557a7cae3f2d3ef6dabb8d71e247e7186b1e
parentMerge pull request #2910 from FearlessTobi/port-4930 (diff)
downloadyuzu-a31c6b2c4e989b6035364cb4ceed44f412f037b7.tar
yuzu-a31c6b2c4e989b6035364cb4ceed44f412f037b7.tar.gz
yuzu-a31c6b2c4e989b6035364cb4ceed44f412f037b7.tar.bz2
yuzu-a31c6b2c4e989b6035364cb4ceed44f412f037b7.tar.lz
yuzu-a31c6b2c4e989b6035364cb4ceed44f412f037b7.tar.xz
yuzu-a31c6b2c4e989b6035364cb4ceed44f412f037b7.tar.zst
yuzu-a31c6b2c4e989b6035364cb4ceed44f412f037b7.zip
-rw-r--r--src/yuzu/configuration/configure_input_player.cpp30
1 files changed, 23 insertions, 7 deletions
diff --git a/src/yuzu/configuration/configure_input_player.cpp b/src/yuzu/configuration/configure_input_player.cpp
index a968cfb5d..bfb14bb43 100644
--- a/src/yuzu/configuration/configure_input_player.cpp
+++ b/src/yuzu/configuration/configure_input_player.cpp
@@ -247,7 +247,22 @@ ConfigureInputPlayer::ConfigureInputPlayer(QWidget* parent, std::size_t player_i
connect(button, &QPushButton::clicked, [=] {
HandleClick(
button_map[button_id],
- [=](const Common::ParamPackage& params) { buttons_param[button_id] = params; },
+ [=](Common::ParamPackage params) {
+ // Workaround for ZL & ZR for analog triggers like on XBOX controllors.
+ // Analog triggers (from controllers like the XBOX controller) would not work
+ // due to a different range of their signals (from 0 to 255 on analog triggers
+ // instead of -32768 to 32768 on analog joysticks). The SDL driver misinterprets
+ // analog triggers as analog joysticks.
+ // TODO: reinterpret the signal range for analog triggers to map the values
+ // correctly. This is required for the correct emulation of the analog triggers
+ // of the GameCube controller.
+ if (button_id == Settings::NativeButton::ZL ||
+ button_id == Settings::NativeButton::ZR) {
+ params.Set("direction", "+");
+ params.Set("threshold", "0.5");
+ }
+ buttons_param[button_id] = params;
+ },
InputCommon::Polling::DeviceType::Button);
});
connect(button, &QPushButton::customContextMenuRequested, [=](const QPoint& menu_location) {
@@ -274,12 +289,13 @@ ConfigureInputPlayer::ConfigureInputPlayer(QWidget* parent, std::size_t player_i
analog_button->setContextMenuPolicy(Qt::CustomContextMenu);
connect(analog_button, &QPushButton::clicked, [=]() {
- HandleClick(analog_map_buttons[analog_id][sub_button_id],
- [=](const Common::ParamPackage& params) {
- SetAnalogButton(params, analogs_param[analog_id],
- analog_sub_buttons[sub_button_id]);
- },
- InputCommon::Polling::DeviceType::Button);
+ HandleClick(
+ analog_map_buttons[analog_id][sub_button_id],
+ [=](const Common::ParamPackage& params) {
+ SetAnalogButton(params, analogs_param[analog_id],
+ analog_sub_buttons[sub_button_id]);
+ },
+ InputCommon::Polling::DeviceType::Button);
});
connect(analog_button, &QPushButton::customContextMenuRequested,
[=](const QPoint& menu_location) {