From f2536cafe55aa3cd70a201d3befaae0c1695698b Mon Sep 17 00:00:00 2001 From: David Marcec Date: Fri, 4 Jan 2019 13:11:17 +1100 Subject: Proper no message handling for AM::PopMessage When we have no messages, we should be returning an error code. --- src/core/hle/service/am/am.cpp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp index d13ce4dca..7a5e9d216 100644 --- a/src/core/hle/service/am/am.cpp +++ b/src/core/hle/service/am/am.cpp @@ -38,6 +38,7 @@ namespace Service::AM { constexpr ResultCode ERR_NO_DATA_IN_CHANNEL{ErrorModule::AM, 0x2}; +constexpr ResultCode ERR_NO_MESSAGES{ErrorModule::AM, 0x3}; constexpr ResultCode ERR_SIZE_OUT_OF_BOUNDS{ErrorModule::AM, 0x1F7}; enum class AppletId : u32 { @@ -460,9 +461,17 @@ void ICommonStateGetter::GetEventHandle(Kernel::HLERequestContext& ctx) { void ICommonStateGetter::ReceiveMessage(Kernel::HLERequestContext& ctx) { LOG_DEBUG(Service_AM, "called"); + const auto message = msg_queue->PopMessage(); IPC::ResponseBuilder rb{ctx, 3}; + + if (message == AppletMessageQueue::AppletMessage::NoMessage) { + LOG_ERROR(Service_AM, "Message queue is empty"); + rb.Push(ERR_NO_MESSAGES); + rb.PushEnum(message); + return; + } rb.Push(RESULT_SUCCESS); - rb.PushEnum(msg_queue->PopMessage()); + rb.PushEnum(message); } void ICommonStateGetter::GetCurrentFocusState(Kernel::HLERequestContext& ctx) { -- cgit v1.2.3