From a33870996b00f18179048debf183f1cb5c499593 Mon Sep 17 00:00:00 2001 From: ReinUsesLisp Date: Fri, 21 Feb 2020 00:28:45 -0300 Subject: vk_state_tracker: Implement dirty flags for depth bias --- src/video_core/renderer_vulkan/vk_rasterizer.cpp | 3 +++ src/video_core/renderer_vulkan/vk_state_tracker.cpp | 9 +++++++++ src/video_core/renderer_vulkan/vk_state_tracker.h | 5 +++++ 3 files changed, 17 insertions(+) (limited to 'src/video_core') diff --git a/src/video_core/renderer_vulkan/vk_rasterizer.cpp b/src/video_core/renderer_vulkan/vk_rasterizer.cpp index 207ef0f0d..be2c4d149 100644 --- a/src/video_core/renderer_vulkan/vk_rasterizer.cpp +++ b/src/video_core/renderer_vulkan/vk_rasterizer.cpp @@ -1015,6 +1015,9 @@ void RasterizerVulkan::UpdateScissorsState(Tegra::Engines::Maxwell3D& gpu) { } void RasterizerVulkan::UpdateDepthBias(Tegra::Engines::Maxwell3D& gpu) { + if (!state_tracker.TouchDepthBias()) { + return; + } const auto& regs = gpu.regs; scheduler.Record([constant = regs.polygon_offset_units, clamp = regs.polygon_offset_clamp, factor = regs.polygon_offset_factor](auto cmdbuf, auto& dld) { diff --git a/src/video_core/renderer_vulkan/vk_state_tracker.cpp b/src/video_core/renderer_vulkan/vk_state_tracker.cpp index 0e00a9079..c75caaa56 100644 --- a/src/video_core/renderer_vulkan/vk_state_tracker.cpp +++ b/src/video_core/renderer_vulkan/vk_state_tracker.cpp @@ -30,6 +30,7 @@ Flags MakeInvalidationFlags() { Flags flags{}; flags[Viewports] = true; flags[Scissors] = true; + flags[DepthBias] = true; return flags; } @@ -76,6 +77,13 @@ void SetupDirtyScissors(Tables& tables) { FillBlock(tables[0], OFF(scissor_test), NUM(scissor_test), Scissors); } +void SetupDirtyDepthBias(Tables& tables) { + auto& table = tables[0]; + table[OFF(polygon_offset_units)] = DepthBias; + table[OFF(polygon_offset_clamp)] = DepthBias; + table[OFF(polygon_offset_factor)] = DepthBias; +} + } // Anonymous namespace StateTracker::StateTracker(Core::System& system) @@ -87,6 +95,7 @@ void StateTracker::Initialize() { SetupDirtyRenderTargets(tables); SetupDirtyViewports(tables); SetupDirtyScissors(tables); + SetupDirtyDepthBias(tables); auto& store = dirty.on_write_stores; store[RenderTargets] = true; diff --git a/src/video_core/renderer_vulkan/vk_state_tracker.h b/src/video_core/renderer_vulkan/vk_state_tracker.h index ba8f3a854..088b47145 100644 --- a/src/video_core/renderer_vulkan/vk_state_tracker.h +++ b/src/video_core/renderer_vulkan/vk_state_tracker.h @@ -21,6 +21,7 @@ enum : u8 { Viewports, Scissors, + DepthBias, }; } // namespace Dirty @@ -41,6 +42,10 @@ public: return Exchange(Dirty::Scissors, false); } + bool TouchDepthBias() { + return Exchange(Dirty::DepthBias, false); + } + private: using Flags = std::remove_reference_t; -- cgit v1.2.3