From d6a1a4385423480573fb9623d511b5028f8393e1 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 12 Aug 2018 03:53:16 -0400 Subject: card_image: Simplify return statement of GetSubdirectories() We don't need to write out the construction long-form, we can just let the language itself work it out off the return type. --- src/core/file_sys/card_image.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/core') diff --git a/src/core/file_sys/card_image.cpp b/src/core/file_sys/card_image.cpp index a4823353e..1188813c7 100644 --- a/src/core/file_sys/card_image.cpp +++ b/src/core/file_sys/card_image.cpp @@ -112,7 +112,7 @@ std::vector> XCI::GetFiles() const { } std::vector> XCI::GetSubdirectories() const { - return std::vector>(); + return {}; } std::string XCI::GetName() const { -- cgit v1.2.3 From 7b6519741bd588006e2b93778d47d4d25e0548c2 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 12 Aug 2018 03:57:06 -0400 Subject: card_image: Use type aliases to shorten definitions We have the aliases, so we may as well use 'em. --- src/core/file_sys/card_image.cpp | 6 +++--- src/core/file_sys/card_image.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'src/core') diff --git a/src/core/file_sys/card_image.cpp b/src/core/file_sys/card_image.cpp index 1188813c7..8e05b9d0e 100644 --- a/src/core/file_sys/card_image.cpp +++ b/src/core/file_sys/card_image.cpp @@ -107,11 +107,11 @@ VirtualFile XCI::GetNCAFileByType(NCAContentType type) const { return nullptr; } -std::vector> XCI::GetFiles() const { +std::vector XCI::GetFiles() const { return {}; } -std::vector> XCI::GetSubdirectories() const { +std::vector XCI::GetSubdirectories() const { return {}; } @@ -119,7 +119,7 @@ std::string XCI::GetName() const { return file->GetName(); } -std::shared_ptr XCI::GetParentDirectory() const { +VirtualDir XCI::GetParentDirectory() const { return file->GetContainingDirectory(); } diff --git a/src/core/file_sys/card_image.h b/src/core/file_sys/card_image.h index e089d737c..4618d9c00 100644 --- a/src/core/file_sys/card_image.h +++ b/src/core/file_sys/card_image.h @@ -71,13 +71,13 @@ public: std::shared_ptr GetNCAByType(NCAContentType type) const; VirtualFile GetNCAFileByType(NCAContentType type) const; - std::vector> GetFiles() const override; + std::vector GetFiles() const override; - std::vector> GetSubdirectories() const override; + std::vector GetSubdirectories() const override; std::string GetName() const override; - std::shared_ptr GetParentDirectory() const override; + VirtualDir GetParentDirectory() const override; protected: bool ReplaceFileWithSubdirectory(VirtualFile file, VirtualDir dir) override; -- cgit v1.2.3