From 732a77d0e83746021ae23b90eab1221ccc1f9bad Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Thu, 3 May 2018 08:06:44 -0400
Subject: memory_hook: Default virtual destructor in the cpp file

Prevents creating multiple copies of the vtable in every translation unit that uses the class.
Also silences a -Wweak-vtables warning
---
 src/core/CMakeLists.txt  |  1 +
 src/core/memory_hook.cpp | 11 +++++++++++
 src/core/memory_hook.h   |  2 +-
 3 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 src/core/memory_hook.cpp

(limited to 'src/core')

diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt
index 45dbd6796..a41e22f4a 100644
--- a/src/core/CMakeLists.txt
+++ b/src/core/CMakeLists.txt
@@ -253,6 +253,7 @@ add_library(core STATIC
     loader/nso.h
     memory.cpp
     memory.h
+    memory_hook.cpp
     memory_hook.h
     memory_setup.h
     perf_stats.cpp
diff --git a/src/core/memory_hook.cpp b/src/core/memory_hook.cpp
new file mode 100644
index 000000000..c61c6c1fb
--- /dev/null
+++ b/src/core/memory_hook.cpp
@@ -0,0 +1,11 @@
+// Copyright 2018 Citra Emulator Project
+// Licensed under GPLv2 or any later version
+// Refer to the license.txt file included.
+
+#include "core/memory_hook.h"
+
+namespace Memory {
+
+MemoryHook::~MemoryHook() = default;
+
+} // namespace Memory
diff --git a/src/core/memory_hook.h b/src/core/memory_hook.h
index feebd850a..e8ea19333 100644
--- a/src/core/memory_hook.h
+++ b/src/core/memory_hook.h
@@ -23,7 +23,7 @@ namespace Memory {
  */
 class MemoryHook {
 public:
-    virtual ~MemoryHook() = default;
+    virtual ~MemoryHook();
 
     virtual boost::optional<bool> IsValidAddress(VAddr addr) = 0;
 
-- 
cgit v1.2.3