From 3268321f4be987aab18c14f3b3ee478f46c7fe38 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 20 Jul 2018 17:17:26 -0400 Subject: param_package: Take std::string by value in string-based Set() function Allows avoiding string copies by letting the strings be moved into the function calls. --- src/common/param_package.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/common/param_package.cpp') diff --git a/src/common/param_package.cpp b/src/common/param_package.cpp index 02399b336..9526ca0c6 100644 --- a/src/common/param_package.cpp +++ b/src/common/param_package.cpp @@ -3,7 +3,9 @@ // Refer to the license.txt file included. #include +#include #include + #include "common/logging/log.h" #include "common/param_package.h" #include "common/string_util.h" @@ -36,7 +38,7 @@ ParamPackage::ParamPackage(const std::string& serialized) { part = Common::ReplaceAll(part, ESCAPE_CHARACTER_ESCAPE, {ESCAPE_CHARACTER}); } - Set(key_value[0], key_value[1]); + Set(key_value[0], std::move(key_value[1])); } } @@ -102,8 +104,8 @@ float ParamPackage::Get(const std::string& key, float default_value) const { } } -void ParamPackage::Set(const std::string& key, const std::string& value) { - data.insert_or_assign(key, value); +void ParamPackage::Set(const std::string& key, std::string value) { + data.insert_or_assign(key, std::move(value)); } void ParamPackage::Set(const std::string& key, int value) { -- cgit v1.2.3