From 46ba1bc40f110a52292290634eefd0c030677eea Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 11 Sep 2018 04:15:36 -0400 Subject: externals: Place font data within cpp files This places the font data within cpp files, which mitigates the possibility of the font data being duplicated within the binary if it's referred to in more than one translation unit in the future. It also stores the data within a std::array, which is more flexible when it comes to operating with the standard library. Furthermore, it makes the data arrays const. This is what we want, as it allows the compiler to store the data within the read-only segment. As it is, having several large sections of mutable data like this just leaves spots in memory that we can accidentally write to (via accidental overruns, what have you) and actually have it work. This ensures the font data remains the same no matter what. --- externals/open_source_archives/CMakeLists.txt | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) (limited to 'externals/open_source_archives/CMakeLists.txt') diff --git a/externals/open_source_archives/CMakeLists.txt b/externals/open_source_archives/CMakeLists.txt index 0b2397203..d1e4bdbe6 100644 --- a/externals/open_source_archives/CMakeLists.txt +++ b/externals/open_source_archives/CMakeLists.txt @@ -1,3 +1,16 @@ -add_library(open_source_archives INTERFACE) +add_library(open_source_archives + src/FontChineseSimplified.cpp + src/FontChineseTraditional.cpp + src/FontExtendedChineseSimplified.cpp + src/FontKorean.cpp + src/FontNintendoExtended.cpp + src/FontStandard.cpp + include/FontChineseSimplified.h + include/FontChineseTraditional.h + include/FontExtendedChineseSimplified.h + include/FontKorean.h + include/FontNintendoExtended.h + include/FontStandard.h +) -target_include_directories(open_source_archives INTERFACE "include/") +target_include_directories(open_source_archives PUBLIC include) -- cgit v1.2.3