From 37aeecd29fb71152b58920a73a95a1df485f98c4 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 22 Jul 2018 23:24:46 -0400 Subject: set: Correct return code size of value in GetAvailableLanguageCodes() The return code should be 32-bit in size. --- src/core/hle/service/set/set.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/hle/service/set/set.cpp b/src/core/hle/service/set/set.cpp index 886133b74..d102aed4b 100644 --- a/src/core/hle/service/set/set.cpp +++ b/src/core/hle/service/set/set.cpp @@ -33,9 +33,9 @@ void SET::GetAvailableLanguageCodes(Kernel::HLERequestContext& ctx) { }}; ctx.WriteBuffer(available_language_codes); - IPC::ResponseBuilder rb{ctx, 4}; + IPC::ResponseBuilder rb{ctx, 3}; rb.Push(RESULT_SUCCESS); - rb.Push(static_cast(available_language_codes.size())); + rb.Push(static_cast(available_language_codes.size())); LOG_DEBUG(Service_SET, "called"); } -- cgit v1.2.3 From 22f448b6327044076959e338811ee576f3dcf093 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 23 Jul 2018 00:06:29 -0400 Subject: set: Implement GetAvailableLanguageCodeCount() This just returns the size of the language code buffer. --- src/core/hle/service/set/set.cpp | 49 +++++++++++++++++++++++----------------- src/core/hle/service/set/set.h | 1 + 2 files changed, 29 insertions(+), 21 deletions(-) diff --git a/src/core/hle/service/set/set.cpp b/src/core/hle/service/set/set.cpp index d102aed4b..4195c9067 100644 --- a/src/core/hle/service/set/set.cpp +++ b/src/core/hle/service/set/set.cpp @@ -11,26 +11,27 @@ namespace Service::Set { +constexpr std::array available_language_codes = {{ + LanguageCode::JA, + LanguageCode::EN_US, + LanguageCode::FR, + LanguageCode::DE, + LanguageCode::IT, + LanguageCode::ES, + LanguageCode::ZH_CN, + LanguageCode::KO, + LanguageCode::NL, + LanguageCode::PT, + LanguageCode::RU, + LanguageCode::ZH_TW, + LanguageCode::EN_GB, + LanguageCode::FR_CA, + LanguageCode::ES_419, + LanguageCode::ZH_HANS, + LanguageCode::ZH_HANT, +}}; + void SET::GetAvailableLanguageCodes(Kernel::HLERequestContext& ctx) { - static constexpr std::array available_language_codes = {{ - LanguageCode::JA, - LanguageCode::EN_US, - LanguageCode::FR, - LanguageCode::DE, - LanguageCode::IT, - LanguageCode::ES, - LanguageCode::ZH_CN, - LanguageCode::KO, - LanguageCode::NL, - LanguageCode::PT, - LanguageCode::RU, - LanguageCode::ZH_TW, - LanguageCode::EN_GB, - LanguageCode::FR_CA, - LanguageCode::ES_419, - LanguageCode::ZH_HANS, - LanguageCode::ZH_HANT, - }}; ctx.WriteBuffer(available_language_codes); IPC::ResponseBuilder rb{ctx, 3}; @@ -40,15 +41,21 @@ void SET::GetAvailableLanguageCodes(Kernel::HLERequestContext& ctx) { LOG_DEBUG(Service_SET, "called"); } +void SET::GetAvailableLanguageCodeCount(Kernel::HLERequestContext& ctx) { + IPC::ResponseBuilder rb{ctx, 3}; + rb.Push(RESULT_SUCCESS); + rb.Push(static_cast(available_language_codes.size())); +} + SET::SET() : ServiceFramework("set") { static const FunctionInfo functions[] = { {0, nullptr, "GetLanguageCode"}, {1, &SET::GetAvailableLanguageCodes, "GetAvailableLanguageCodes"}, {2, nullptr, "MakeLanguageCode"}, - {3, nullptr, "GetAvailableLanguageCodeCount"}, + {3, &SET::GetAvailableLanguageCodeCount, "GetAvailableLanguageCodeCount"}, {4, nullptr, "GetRegionCode"}, {5, &SET::GetAvailableLanguageCodes, "GetAvailableLanguageCodes2"}, - {6, nullptr, "GetAvailableLanguageCodeCount2"}, + {6, &SET::GetAvailableLanguageCodeCount, "GetAvailableLanguageCodeCount2"}, {7, nullptr, "GetKeyCodeMap"}, {8, nullptr, "GetQuestFlag"}, }; diff --git a/src/core/hle/service/set/set.h b/src/core/hle/service/set/set.h index ec0df0152..a2472ec4c 100644 --- a/src/core/hle/service/set/set.h +++ b/src/core/hle/service/set/set.h @@ -36,6 +36,7 @@ public: private: void GetAvailableLanguageCodes(Kernel::HLERequestContext& ctx); + void GetAvailableLanguageCodeCount(Kernel::HLERequestContext& ctx); }; } // namespace Service::Set -- cgit v1.2.3