From 45aee996c191afe377dffbe88612f5912b2e8cfb Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 13 Jan 2021 22:37:37 -0500 Subject: configure_motion_touch: Prevent use after move in ApplyConfiguration() touch_engine was being compared against after being moved into the setter for the engine, so this comparison wouldn't behave properly. --- src/yuzu/configuration/configure_motion_touch.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/yuzu/configuration/configure_motion_touch.cpp b/src/yuzu/configuration/configure_motion_touch.cpp index 9543f086d..68110c195 100644 --- a/src/yuzu/configuration/configure_motion_touch.cpp +++ b/src/yuzu/configuration/configure_motion_touch.cpp @@ -328,14 +328,13 @@ void ConfigureMotionTouch::ApplyConfiguration() { std::string touch_engine = ui->touch_provider->currentData().toString().toStdString(); Common::ParamPackage touch_param{}; - touch_param.Set("engine", std::move(touch_engine)); - if (touch_engine == "cemuhookudp") { touch_param.Set("min_x", min_x); touch_param.Set("min_y", min_y); touch_param.Set("max_x", max_x); touch_param.Set("max_y", max_y); } + touch_param.Set("engine", std::move(touch_engine)); Settings::values.touch_device = touch_param.Serialize(); Settings::values.use_touch_from_button = ui->touch_from_button_checkbox->isChecked(); -- cgit v1.2.3