From 3e03391a49e6a9e186ac3e7029388036f59b7e42 Mon Sep 17 00:00:00 2001 From: ReinUsesLisp Date: Fri, 15 Jan 2021 02:58:55 -0300 Subject: vk_buffer_cache: Remove unused function --- src/video_core/renderer_vulkan/vk_buffer_cache.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/video_core/renderer_vulkan/vk_buffer_cache.cpp b/src/video_core/renderer_vulkan/vk_buffer_cache.cpp index 4d517c547..58c710344 100644 --- a/src/video_core/renderer_vulkan/vk_buffer_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_buffer_cache.cpp @@ -34,10 +34,6 @@ constexpr VkAccessFlags UPLOAD_ACCESS_BARRIERS = constexpr VkAccessFlags TRANSFORM_FEEDBACK_WRITE_ACCESS = VK_ACCESS_TRANSFORM_FEEDBACK_WRITE_BIT_EXT | VK_ACCESS_TRANSFORM_FEEDBACK_COUNTER_WRITE_BIT_EXT; -std::unique_ptr CreateStreamBuffer(const Device& device, VKScheduler& scheduler) { - return std::make_unique(device, scheduler); -} - } // Anonymous namespace Buffer::Buffer(const Device& device_, VKMemoryManager& memory_manager, VKScheduler& scheduler_, -- cgit v1.2.3 From 71264ce9a799993d57a33b552070d22f5f6aeae5 Mon Sep 17 00:00:00 2001 From: ReinUsesLisp Date: Fri, 15 Jan 2021 02:59:22 -0300 Subject: video_core: Enforce -Wunused-function Stops us from merging code with unused functions in the future. If something is invoked behind conditionally evaluated code in a way that the language can't see it (e.g. preprocessor macros), the potentially unused function should use [[maybe_unused]]. --- src/video_core/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/src/video_core/CMakeLists.txt b/src/video_core/CMakeLists.txt index f7b9d7f86..7f3db993c 100644 --- a/src/video_core/CMakeLists.txt +++ b/src/video_core/CMakeLists.txt @@ -314,6 +314,7 @@ else() -Werror=shadow -Werror=switch -Werror=type-limits + -Werror=unused-function -Werror=unused-variable $<$:-Werror=class-memaccess> -- cgit v1.2.3 From 06e0506cb36b951991d41e03eebadba7ae28bc50 Mon Sep 17 00:00:00 2001 From: ReinUsesLisp Date: Fri, 15 Jan 2021 03:09:30 -0300 Subject: cmake: Enforce -Wunused-function code-base wide --- src/CMakeLists.txt | 1 + src/video_core/CMakeLists.txt | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index ee6f61f16..4daec5350 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -69,6 +69,7 @@ else() -Werror=reorder -Werror=switch -Werror=uninitialized + -Werror=unused-function -Werror=unused-result -Werror=unused-variable -Wextra diff --git a/src/video_core/CMakeLists.txt b/src/video_core/CMakeLists.txt index 7f3db993c..f7b9d7f86 100644 --- a/src/video_core/CMakeLists.txt +++ b/src/video_core/CMakeLists.txt @@ -314,7 +314,6 @@ else() -Werror=shadow -Werror=switch -Werror=type-limits - -Werror=unused-function -Werror=unused-variable $<$:-Werror=class-memaccess> -- cgit v1.2.3