From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Thu, 14 May 2020 23:15:35 +0100 Subject: Enable some more clang-tidy linter checks (#4738) * Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate --- src/mbedTLS++/BlockingSslClientSocket.cpp | 2 +- src/mbedTLS++/SslContext.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src/mbedTLS++') diff --git a/src/mbedTLS++/BlockingSslClientSocket.cpp b/src/mbedTLS++/BlockingSslClientSocket.cpp index c3d928fe0..bc9d07157 100644 --- a/src/mbedTLS++/BlockingSslClientSocket.cpp +++ b/src/mbedTLS++/BlockingSslClientSocket.cpp @@ -356,7 +356,7 @@ void cBlockingSslClientSocket::OnReceivedData(const char * a_Data, size_t a_Size void cBlockingSslClientSocket::SetLink(cTCPLinkPtr a_Link) { - m_Socket = a_Link; + m_Socket = std::move(a_Link); } diff --git a/src/mbedTLS++/SslContext.cpp b/src/mbedTLS++/SslContext.cpp index 581b8fb50..4847e9322 100644 --- a/src/mbedTLS++/SslContext.cpp +++ b/src/mbedTLS++/SslContext.cpp @@ -41,7 +41,7 @@ int cSslContext::Initialize(std::shared_ptr a_Config) } // Check the Config: - m_Config = a_Config; + m_Config = std::move(a_Config); if (m_Config == nullptr) { ASSERT(!"Config must not be nullptr"); -- cgit v1.2.3