From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Thu, 14 May 2020 23:15:35 +0100 Subject: Enable some more clang-tidy linter checks (#4738) * Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate --- src/IniFile.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/IniFile.cpp') diff --git a/src/IniFile.cpp b/src/IniFile.cpp index 375c9d61f..8b051dd9a 100644 --- a/src/IniFile.cpp +++ b/src/IniFile.cpp @@ -934,7 +934,7 @@ AStringVector ReadUpgradeIniPorts( AStringVector Ports; - for (auto pair : a_Settings.GetValues(a_KeyName)) + for (const auto & pair : a_Settings.GetValues(a_KeyName)) { if (pair.first != a_PortsValueName) { -- cgit v1.2.3