From a4dbb5c58270959884c17d720185da06464fa256 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Wed, 2 May 2018 08:50:36 +0100 Subject: Prefer static_cast to reinterpret_cast (#4223) * Change reinterpret_cast -> static_cast wherever possible * Remove more unnecessary `const_cast`s. reinterpret_casts should be avoided for the same reason as c-style casts - they don't do any type-checking. reinterpret_cast was mainly being used for down-casting in inheritance hierarchies but static_cast works just as well while also making sure that there is actually an inheritance relationship there. --- src/HTTP/HTTPServer.cpp | 2 +- src/HTTP/SslHTTPServerConnection.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src/HTTP') diff --git a/src/HTTP/HTTPServer.cpp b/src/HTTP/HTTPServer.cpp index aff2331a6..24f10ff16 100644 --- a/src/HTTP/HTTPServer.cpp +++ b/src/HTTP/HTTPServer.cpp @@ -216,7 +216,7 @@ void cHTTPServer::NewRequest(cHTTPServerConnection & a_Connection, cHTTPIncoming void cHTTPServer::RequestBody(cHTTPServerConnection & a_Connection, cHTTPIncomingRequest & a_Request, const void * a_Data, size_t a_Size) { - m_Callbacks->OnRequestBody(a_Connection, a_Request, reinterpret_cast(a_Data), a_Size); + m_Callbacks->OnRequestBody(a_Connection, a_Request, static_cast(a_Data), a_Size); } diff --git a/src/HTTP/SslHTTPServerConnection.cpp b/src/HTTP/SslHTTPServerConnection.cpp index 20554708a..9c2993fbb 100644 --- a/src/HTTP/SslHTTPServerConnection.cpp +++ b/src/HTTP/SslHTTPServerConnection.cpp @@ -83,7 +83,7 @@ void cSslHTTPServerConnection::OnReceivedData(const char * a_Data, size_t a_Size void cSslHTTPServerConnection::SendData(const void * a_Data, size_t a_Size) { - const char * OutgoingData = reinterpret_cast(a_Data); + const char * OutgoingData = static_cast(a_Data); size_t pos = 0; for (;;) { -- cgit v1.2.3