From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Thu, 14 May 2020 23:15:35 +0100 Subject: Enable some more clang-tidy linter checks (#4738) * Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate --- src/HTTP/UrlClient.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/HTTP/UrlClient.cpp') diff --git a/src/HTTP/UrlClient.cpp b/src/HTTP/UrlClient.cpp index 9ee453321..315856f69 100644 --- a/src/HTTP/UrlClient.cpp +++ b/src/HTTP/UrlClient.cpp @@ -159,7 +159,7 @@ protected: } - std::pair DoRequest(std::shared_ptr a_Self); + std::pair DoRequest(const std::shared_ptr & a_Self); // cNetwork::cConnectCallbacks override: TCP link connected: @@ -572,7 +572,7 @@ void cUrlClientRequest::OnRemoteClosed() -std::pair cUrlClientRequest::DoRequest(std::shared_ptr a_Self) +std::pair cUrlClientRequest::DoRequest(const std::shared_ptr & a_Self) { // We need a shared pointer to self, care must be taken not to pass any other ptr: ASSERT(a_Self.get() == this); @@ -630,7 +630,7 @@ std::pair cUrlClient::Get( const AString & a_URL, cCallbacksPtr && a_Callbacks, AStringMap a_Headers, - AString a_Body, + const AString & a_Body, AStringMap a_Options ) { -- cgit v1.2.3