diff options
author | Mattes D <github@xoft.cz> | 2014-12-25 00:34:54 +0100 |
---|---|---|
committer | Mattes D <github@xoft.cz> | 2014-12-25 00:34:54 +0100 |
commit | 081e7ddd028d9382bd52c2b117dae6b6f84225e5 (patch) | |
tree | 6e2564eaee74ab2615bb0c1b6925498da183ee97 /src/OSSupport/IsThread.h | |
parent | Merge pull request #1686 from mc-server/PlaceBlockRefactor (diff) | |
download | cuberite-081e7ddd028d9382bd52c2b117dae6b6f84225e5.tar cuberite-081e7ddd028d9382bd52c2b117dae6b6f84225e5.tar.gz cuberite-081e7ddd028d9382bd52c2b117dae6b6f84225e5.tar.bz2 cuberite-081e7ddd028d9382bd52c2b117dae6b6f84225e5.tar.lz cuberite-081e7ddd028d9382bd52c2b117dae6b6f84225e5.tar.xz cuberite-081e7ddd028d9382bd52c2b117dae6b6f84225e5.tar.zst cuberite-081e7ddd028d9382bd52c2b117dae6b6f84225e5.zip |
Diffstat (limited to '')
-rw-r--r-- | src/OSSupport/IsThread.h | 19 |
1 files changed, 14 insertions, 5 deletions
diff --git a/src/OSSupport/IsThread.h b/src/OSSupport/IsThread.h index 131c6950e..f642c8724 100644 --- a/src/OSSupport/IsThread.h +++ b/src/OSSupport/IsThread.h @@ -25,23 +25,28 @@ In the descending class' constructor call the Start() method to start the thread class cIsThread { protected: - /// This is the main thread entrypoint + /** This is the main thread entrypoint. + This function, overloaded by the descendants, is called in the new thread. */ virtual void Execute(void) = 0; - /// The overriden Execute() method should check this value periodically and terminate if this is true + /** The overriden Execute() method should check this value periodically and terminate if this is true. */ volatile bool m_ShouldTerminate; +private: + /** Wrapper for Execute() that waits for the initialization event, to prevent race conditions in thread initialization. */ + void DoExecute(void); + public: cIsThread(const AString & a_ThreadName); virtual ~cIsThread(); - /// Starts the thread; returns without waiting for the actual start + /** Starts the thread; returns without waiting for the actual start. */ bool Start(void); - /// Signals the thread to terminate and waits until it's finished + /** Signals the thread to terminate and waits until it's finished. */ void Stop(void); - /// Waits for the thread to finish. Doesn't signalize the ShouldTerminate flag + /** Waits for the thread to finish. Doesn't signalize the ShouldTerminate flag. */ bool Wait(void); /** Returns true if the thread calling this function is the thread contained within this object. */ @@ -50,6 +55,10 @@ public: protected: AString m_ThreadName; std::thread m_Thread; + + /** The event that is used to wait with the thread's execution until the thread object is fully initialized. + This prevents the IsCurrentThread() call to fail because of a race-condition. */ + cEvent m_evtStart; } ; |