From 8b23811d2ac5c056ff49f2ab4fca3447a9fdca42 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Fri, 26 Aug 2016 14:54:29 -0700 Subject: Fix clang-tidy warnings in bootable/recovery. * Use const reference type for read-only parameters. Bug: 30407689 * Use faster overloaded string find function. Bug: 30411878 * Add parentheses around macro parameters. Bug: 28705665 Test: build with WITH_TIDY=1 Change-Id: I4e8e5748bfa4ae89871f1fb5fa4624d372530d75 --- wear_touch.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'wear_touch.cpp') diff --git a/wear_touch.cpp b/wear_touch.cpp index f22d40b88..51a1d31b2 100644 --- a/wear_touch.cpp +++ b/wear_touch.cpp @@ -122,7 +122,7 @@ void* WearSwipeDetector::touch_thread(void* cookie) { return NULL; } -#define test_bit(bit, array) (array[bit/8] & (1<<(bit%8))) +#define test_bit(bit, array) ((array)[(bit)/8] & (1<<((bit)%8))) int WearSwipeDetector::openDevice(const char *device) { int fd = open(device, O_RDONLY); -- cgit v1.2.3