summaryrefslogtreecommitdiffstats
path: root/applypatch
diff options
context:
space:
mode:
authorTianjie Xu <xunchang@google.com>2020-07-24 21:12:49 +0200
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-07-24 21:12:49 +0200
commit74538db6848e1a315923ec765436b62eb3147537 (patch)
treec7a4a5e7fb5b66842c745aef778e6d4cfc2b886d /applypatch
parentMerge "Add recovery support of dynamic fingerprints" am: dca4844328 (diff)
parentMerge changes I0f3f0333,If447b2cf (diff)
downloadandroid_bootable_recovery-74538db6848e1a315923ec765436b62eb3147537.tar
android_bootable_recovery-74538db6848e1a315923ec765436b62eb3147537.tar.gz
android_bootable_recovery-74538db6848e1a315923ec765436b62eb3147537.tar.bz2
android_bootable_recovery-74538db6848e1a315923ec765436b62eb3147537.tar.lz
android_bootable_recovery-74538db6848e1a315923ec765436b62eb3147537.tar.xz
android_bootable_recovery-74538db6848e1a315923ec765436b62eb3147537.tar.zst
android_bootable_recovery-74538db6848e1a315923ec765436b62eb3147537.zip
Diffstat (limited to 'applypatch')
-rw-r--r--applypatch/imgdiff.cpp15
-rw-r--r--applypatch/include/applypatch/imgdiff_image.h4
2 files changed, 10 insertions, 9 deletions
diff --git a/applypatch/imgdiff.cpp b/applypatch/imgdiff.cpp
index 91007ac3b..85860281a 100644
--- a/applypatch/imgdiff.cpp
+++ b/applypatch/imgdiff.cpp
@@ -1038,20 +1038,21 @@ bool ZipModeImage::AddSplitImageFromChunkList(const ZipModeImage& tgt_image,
split_tgt_image.Initialize(aligned_tgt_chunks, {});
split_tgt_image.MergeAdjacentNormalChunks();
- // Construct the dummy source file based on the src_ranges.
- std::vector<uint8_t> src_content;
+ // Construct the split source file based on the split src ranges.
+ std::vector<uint8_t> split_src_content;
for (const auto& r : split_src_ranges) {
size_t end = std::min(src_image.file_content_.size(), r.second * BLOCK_SIZE);
- src_content.insert(src_content.end(), src_image.file_content_.begin() + r.first * BLOCK_SIZE,
- src_image.file_content_.begin() + end);
+ split_src_content.insert(split_src_content.end(),
+ src_image.file_content_.begin() + r.first * BLOCK_SIZE,
+ src_image.file_content_.begin() + end);
}
// We should not have an empty src in our design; otherwise we will encounter an error in
- // bsdiff since src_content.data() == nullptr.
- CHECK(!src_content.empty());
+ // bsdiff since split_src_content.data() == nullptr.
+ CHECK(!split_src_content.empty());
ZipModeImage split_src_image(true);
- split_src_image.Initialize(split_src_chunks, src_content);
+ split_src_image.Initialize(split_src_chunks, split_src_content);
split_tgt_images->push_back(std::move(split_tgt_image));
split_src_images->push_back(std::move(split_src_image));
diff --git a/applypatch/include/applypatch/imgdiff_image.h b/applypatch/include/applypatch/imgdiff_image.h
index 671605160..aa8d129c3 100644
--- a/applypatch/include/applypatch/imgdiff_image.h
+++ b/applypatch/include/applypatch/imgdiff_image.h
@@ -211,7 +211,7 @@ class ZipModeImage : public Image {
bool Initialize(const std::string& filename) override;
- // Initialize a dummy ZipModeImage from an existing ImageChunk vector. For src img pieces, we
+ // Initialize a fake ZipModeImage from an existing ImageChunk vector. For src img pieces, we
// reconstruct a new file_content based on the source ranges; but it's not needed for the tgt img
// pieces; because for each chunk both the data and their offset within the file are unchanged.
void Initialize(const std::vector<ImageChunk>& chunks, const std::vector<uint8_t>& file_content) {
@@ -265,7 +265,7 @@ class ZipModeImage : public Image {
const std::vector<ZipModeImage>& split_src_images,
std::vector<SortedRangeSet>& split_src_ranges,
size_t total_tgt_size);
- // Construct the dummy split images based on the chunks info and source ranges; and move them into
+ // Construct the fake split images based on the chunks info and source ranges; and move them into
// the given vectors. Return true if we add a new split image into |split_tgt_images|, and
// false otherwise.
static bool AddSplitImageFromChunkList(const ZipModeImage& tgt_image,